Skip to content

gh-156784: unignore error port unreachable in proactor - #156788

Merged
kumaraditya303 merged 18 commits into
python:mainfrom
graingert:unignore-error-port-unreachable-in-proactor
Oct 20, 2026
Merged

gh-156784: unignore error port unreachable in proactor #156788
kumaraditya303 merged 18 commits into
python:mainfrom
graingert:unignore-error-port-unreachable-in-proactor

Conversation

@graingert

@graingert graingert commented Sep 1, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot mentioned this pull request Sep 1, 2026
Closed
@graingert

graingert commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

This PR depends on two other PRs: #156726 and #156718

@esoma

esoma commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

fwiw as the author of #32011 this change makes sense to me. I thought I'd had a conversation with someone on whether to suppress the error getting reported or not, but I can't seem to find it.

For some context, prior to #32011 it would have been reported to the transport's error_received as an OSError.

@graingert
Merge branch 'main' into fix-proactor-error-hang
60187dd
@graingert
fix DatagramTransport when errror_recieved calls sendto
d57cb23
@graingert
Merge branch 'main' of github.com:python/cpython into fix-proactor-er…
bb80478 
…ror-hang

# Conflicts:
#	Lib/test/test_asyncio/test_events.py
@graingert
Merge branch 'fix-proactor-error-hang' into unignore-error-port-unrea…
99dd5a1 
…chable-in-proactor

# Conflicts:
#	Misc/NEWS.d/next/Library/2026-08-31-00-00-00.gh-issue-127057.N9yg62.rst
@graingert
Merge branch 'main' of github.com:python/cpython into unignore-error-…
bad71a2 
…port-unreachable-in-proactor

# Conflicts:
#	Lib/asyncio/proactor_events.py
#	Lib/test/test_asyncio/test_events.py
graingert
graingert commented Sep 16, 2026
View reviewed changes
Comment thread Lib/asyncio/proactor_events.py Outdated
graingert
graingert commented Sep 16, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2026-09-01-00-00-00.gh-issue-156784.8gvtt4.rst Outdated
@graingert
graingert marked this pull request as ready for review September 16, 2026 09:29
@graingert graingert added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Sep 16, 2026
@graingert

graingert commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

@kumaraditya303 please could I get a review of this PR as I'd like to get it in before the last python 3.13 bug fix release

@kumaraditya303

kumaraditya303 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

please could I get a review of this PR as I'd like to get it in before the last python 3.13 bug fix release

This behaviour has been present in all versions of 3.13 as such I don't feel comfortable changing it in last release.

@graingert graingert removed the needs backport to 3.13 only security fixes label Oct 7, 2026
@graingert

graingert commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Ok I've removed the label for 3.13

kumaraditya303
kumaraditya303 reviewed Oct 19, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2026-09-01-00-00-00.gh-issue-156784.8gvtt4.rst Outdated
@kumaraditya303 kumaraditya303 removed the needs backport to 3.14 bugs and security fixes label Oct 20, 2026
@kumaraditya303

kumaraditya303 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Let's only backport this for 3.15 as it is fairly new, 3.14 it out for a while and I don't think this is worth changing behavior in bug fix release.

@kumaraditya303
kumaraditya303 merged commit 0815fe3 into python:main Oct 20, 2026
59 checks passed
@miss-islington-app

miss-islington-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

Thanks @graingert for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

GH-159872 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 20, 2026
@graingert
graingert deleted the unignore-error-port-unreachable-in-proactor branch October 20, 2026 11:28
kumaraditya303 pushed a commit that referenced this pull request Oct 21, 2026
@miss-islington @graingert
[3.15] gh-156784: do not ignore error port unreachable in proactor ev…
482cf6b 
…ent loop implementation (GH-156788) (#159872)

gh-156784: do not ignore error port unreachable in proactor event loop implementation (GH-156788)
(cherry picked from commit 0815fe3)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The fix in gh-91227 is incorrect, the SelectorEventLoop has the correct behaviour calling error_received and continuing to run the Transport

3 participants

@graingert @esoma @kumaraditya303